Re: [PATCH] x86: vdso: eliminate some redundant loads in update_vsyscall

[Thomas Gleixner]

On Thu, 15 Mar 2018, Rasmus Villemoes wrote:
> diff --git a/arch/x86/entry/vsyscall/vsyscall_gtod.c b/arch/x86/entry/vsyscall/vsyscall_gtod.c
> index e1216dd95c04..550447a43a50 100644
> --- a/arch/x86/entry/vsyscall/vsyscall_gtod.c
> +++ b/arch/x86/entry/vsyscall/vsyscall_gtod.c
> @@ -31,6 +31,7 @@ void update_vsyscall(struct timekeeper *tk)
>  {
>  	int vclock_mode = tk->tkr_mono.clock->archdata.vclock_mode;
>  	struct vsyscall_gtod_data *vdata = &vsyscall_gtod_data;
> +	int shift;

Not that it is a big issue, but the shift value in the timekeeper is
unsigned. So please use an unsigned here as well.

Thanks,

	tglx