Re: [PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled
From: Lee Duncan
Date: Thu Mar 15 2018 - 06:37:32 EST
I reviewed this several days before but mistakenly replied only to the open-iscsi list.
Signed-off-by: Lee Duncan <lduncan@xxxxxxxx>
--
Lee-Man Duncan
Sent from my iPhone, dude
> On Mar 14, 2018, at 10:11 PM, Martin K. Petersen <martin.petersen@xxxxxxxxxx> wrote:
>
>
>> iscsi tcp will first send out data, then calculate and send data
>> digest. If we don't have BDI_CAP_STABLE_WRITES, the page cache will
>> be written in spite of the on going writeback. Consequently, wrong
>> digest will be got and sent to target.
>>
>> To fix this, set BDI_CAP_STABLE_WRITES when data digest is enabled
>> in iscsi_tcp .slave_configure callback.
>
> Lee, Chris: Please review!
>
> --
> Martin K. Petersen Oracle Linux Engineering
>
> --
> You received this message because you are subscribed to a topic in the Google Groups "open-iscsi" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/topic/open-iscsi/owLIZAXfgoA/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to open-iscsi+unsubscribe@xxxxxxxxxxxxxxxxx
> To post to this group, send email to open-iscsi@xxxxxxxxxxxxxxxxx
> Visit this group at https://groups.google.com/group/open-iscsi.
> For more options, visit https://groups.google.com/d/optout.