Re: [PATCH v1 1/3] drm/tegra: plane: Fix RGB565 plane format on older Tegra's
From: Dmitry Osipenko
Date: Thu Mar 15 2018 - 08:58:19 EST
On 15.03.2018 15:48, Dmitry Osipenko wrote:
> On 15.03.2018 13:27, Thierry Reding wrote:
>> On Thu, Mar 15, 2018 at 04:00:23AM +0300, Dmitry Osipenko wrote:
>>> Simplify opaque format adjustment by removing format checking. There are
>>> only 4 formats that require the adjustment and so this way is less error
>>> prone, avoiding mishandling native formats, like in this case RGB565 is
>>> the format that was erroneously treated as invalid.
>>>
>>> Fixes: ebae8d07435a ("drm/tegra: dc: Implement legacy blending")
>>> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
>>> ---
>>> drivers/gpu/drm/tegra/dc.c | 11 ++---------
>>> drivers/gpu/drm/tegra/plane.c | 21 ++++++---------------
>>> drivers/gpu/drm/tegra/plane.h | 2 +-
>>> 3 files changed, 9 insertions(+), 25 deletions(-)
>>
>> I've applied a slightly different version of this which doesn't rework
>> as much of the surrounding code and is therefore easier to backport to
>> v4.16.
>
> Okay. Please don't forget to push the modified patch, I don't see it in the FDO git.
See it now.