Re: [PATCH 03/14] x86: use dma-direct
From: Thomas Gleixner
Date: Thu Mar 15 2018 - 09:46:02 EST
On Thu, 15 Mar 2018, Christoph Hellwig wrote:
> On Thu, Mar 15, 2018 at 01:53:52PM +0100, Thomas Gleixner wrote:
> > > > > The generic dma-direct implementation is now functionally equivalent to
> > > > > the x86 nommu dma_map implementation, so switch over to using it.
> > > >
> > > > Can you please convert the various drivers first and then remove the
> > > > unused code?
> > >
> > > Which various drivers?
> > >
> > > > > Note that the various iommu drivers are switched from x86_dma_supported
> >
> > The various iommu drivers ....
>
> It doesn't really make any sense to switch them separately. They've
> inherited the ops from x86 which used to override it on an arch level,
> and we've now generalized the exactly same implementation to common code.
Fair enough.