Re: [PATCHv3] iommu/intel: Ratelimit each dmar fault printing

From: Joerg Roedel
Date: Thu Mar 15 2018 - 11:28:34 EST


On Thu, Mar 15, 2018 at 02:42:00PM +0000, Dmitry Safonov wrote:
> But even with loop-limit we will need ratelimit each printk() *also*.
> Otherwise loop-limit will be based on time spent printing, not on
> anything else..
> The patch makes sense even with loop-limit in my opinion.

Looks like I mis-read your patch, somehow it looked to me as if you
replace all 'ratelimited' usages with a call to __ratelimit(), but you
just move 'ratelimited' into the loop, which actually makes sense.

But still, this alone is no proper fix for the soft-lockups you are
seeing.


Joerg