Re: [PATCH 7/9] x86/dumpstack: Add a show_ip() function

[Josh Poimboeuf]

On Thu, Mar 15, 2018 at 04:44:46PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@xxxxxxx>
> 
> Which shows the Istruction Pointer along with the insn bytes around it.
> Use it whenever we print rIP.

s/Istruction/Instruction/

> diff --git a/arch/x86/kernel/process_32.c b/arch/x86/kernel/process_32.c
> index 5224c6099184..3d1f1226b972 100644
> --- a/arch/x86/kernel/process_32.c
> +++ b/arch/x86/kernel/process_32.c
> @@ -76,9 +76,7 @@ void __show_regs(struct pt_regs *regs, int all)
>  		savesegment(gs, gs);
>  	}
>  
> -	printk(KERN_DEFAULT "EIP: %pS\n", (void *)regs->ip);
> -	printk(KERN_DEFAULT "EFLAGS: %08lx CPU: %d\n", regs->flags,
> -		raw_smp_processor_id());
> +	show_ip(regs, KERN_DEFAULT);

Did you intentionally remove the printing of EFLAGS?

-- 
Josh