Re: [PATCH v2 7/7] kbuild: link vmlinux only once for CONFIG_TRIM_UNUSED_KSYMS

[Masahiro Yamada]

2018-03-16 11:32 GMT+09:00 Nicolas Pitre <nicolas.pitre@xxxxxxxxxx>:
> On Fri, 16 Mar 2018, Masahiro Yamada wrote:
>
>> +# Recurse until adjust_autoksyms.sh is satisfied
>> +PHONY += autoksyms_recursive
>> +autoksyms_recursive: $(vmlinux-deps)
>> +     $(Q)$(CONFIG_SHELL) $(srctree)/scripts/adjust_autoksyms.sh  \
>>         "$(MAKE) -f $(srctree)/Makefile vmlinux"
>> -endif
>>
>>  # For the kernel to actually contain only the needed exported symbols,
>>  # we have to build modules as well to determine what those symbols are.
>> @@ -1034,7 +1024,13 @@ cmd_link-vmlinux =                                                 \
>>       $(CONFIG_SHELL) $< $(LD) $(LDFLAGS) $(LDFLAGS_vmlinux) ;    \
>>       $(if $(ARCH_POSTLINK), $(MAKE) -f $(ARCH_POSTLINK) $@, true)
>>
>> -vmlinux: scripts/link-vmlinux.sh vmlinux_prereq $(vmlinux-deps) FORCE
>> +vmlinux: scripts/link-vmlinux.sh autoksyms_recursive $(vmlinux-deps) FORCE
>
> Don't you have to make the autoksyms_recursive dependency conditional on
> CONFIG_TRIM_UNUSED_KSYMS?
>

Oops, I accidentally removed that conditional.

I will fix it shortly.  Thanks!


-- 
Best Regards
Masahiro Yamada