Re: [RFC 0/4] gpio-backlight: remove platform data support
From: Daniel Thompson
Date: Fri Mar 16 2018 - 07:11:56 EST
On Thu, Mar 15, 2018 at 03:41:58PM -0700, Dmitry Torokhov wrote:
> Hi,
>
> This series attempts to remove platform data support from gpio_blackllist
> driver and switch it over to generic device properties/GPIO tables.
> The only user of platform data was SuperH Ecovec24 board; please take a
> look at patch #2 that tries to only register backlight when the board is
> using LDC and not DVI.
Can't comment on patch #2 but, from the backlight side of things I have
no objections.
Daniel.
>
> Please note that I do not have the hardware (do we even care about
> ecovec24? I'd like to rip out platform data support from tsc2007 as
> well, but ecovec24 is using custom pendown handler and GPIOs have
> to be switched off from interrupt mode to GPIO and back in that
> pendown handler, which is all quite messy. If we do not care about
> this board I'd much rather removed that custom pendown).
>
> Thanks!
>
> Dmitry Torokhov (4):
> backlight: gpio_backlight: use generic device properties
> sh: ecovec24: conditionally register backlight device
> sh: ecovec24: convert backlight to use device properties
> backlight: gpio_backlight: remove platform data support
>
> arch/sh/boards/mach-ecovec24/setup.c | 47 ++++++----
> drivers/video/backlight/gpio_backlight.c | 93 +++-----------------
> include/linux/platform_data/gpio_backlight.h | 20 -----
> 3 files changed, 46 insertions(+), 114 deletions(-)
> delete mode 100644 include/linux/platform_data/gpio_backlight.h
>
> --
> Dmitry
>