Re: [PATCH v2 13/36] x86/ioport: add ksys_ioperm() helper; remove in-kernel calls to sys_ioperm()

[Dominik Brodowski]

On Fri, Mar 16, 2018 at 01:00:48PM +0100, Thomas Gleixner wrote:
> On Thu, 15 Mar 2018, Dominik Brodowski wrote:
> 
> > Using this helper allows us to avoid the in-kernel calls to the sys_ioperm()
> > syscall.
> > 
> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > Cc: Jiri Slaby <jslaby@xxxxxxxx>
> > Cc: x86@xxxxxxxxxx
> > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>
> 
> Please add a few lines explaining the ksys_ prefix as you did in your reply
> to Christoph. Other than that:
> 
> Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

Thanks! The commit message now reads

	Using this helper allows us to avoid the in-kernel calls to the sys_ioperm()
	syscall. The ksys_ prefix denotes that this function is meant as a drop-in
	replacement for the syscall. In particular, it uses the same calling
	convention as sys_ioperm().

Does that sound OK?

Thanks,
	Dominik