Re: [PATCH v2] netns: send uevent messages

[David Miller]

From: Christian Brauner <christian.brauner@xxxxxxxxxx>
Date: Fri, 16 Mar 2018 13:50:30 +0100

> +static int uevent_net_broadcast(struct sock *usk, struct sk_buff *skb,
> +				struct netlink_ext_ack *extack)
> +{
> +	int ret;
> +	/* u64 to chars: 2^64 - 1 = 21 chars */
> +	char buf[sizeof("SEQNUM=") + 21];
> +	struct sk_buff *skbc;

I hate to be difficult, but please use reverse christmas tree ordering
for local variables.

> +static int uevent_net_rcv_skb(struct sk_buff *skb, struct nlmsghdr *nlh,
> +			      struct netlink_ext_ack *extack)
> +{
> +	int ret;
> +	struct net *net;

Likewise.

Thank you.