Re: [PATCH v9 10/61] xarray: Change definition of sibling entries

From: Josef Bacik
Date: Fri Mar 16 2018 - 15:00:13 EST


On Tue, Mar 13, 2018 at 06:25:48AM -0700, Matthew Wilcox wrote:
> From: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
>
> Instead of storing a pointer to the slot containing the canonical entry,
> store the offset of the slot. Produces slightly more efficient code
> (~300 bytes) and simplifies the implementation.
>
> Signed-off-by: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
> ---
> include/linux/xarray.h | 93 ++++++++++++++++++++++++++++++++++++++++++++++++++
> lib/radix-tree.c | 66 +++++++++++------------------------
> 2 files changed, 112 insertions(+), 47 deletions(-)
>

Reviewed-by: Josef Bacik <jbacik@xxxxxx>

Thanks,

Josef