Re: [PATCH 02/14] mm/hmm: fix header file if/else/endif maze

From: Andrew Morton
Date: Fri Mar 16 2018 - 17:10:06 EST

Next message: Florian Fainelli: "Re: [PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev"
Previous message: Eric W. Biederman: "Re: [PATCH 13/22] signal: Move addr_lsb into the _sigfault union for clarity"
In reply to: jglisse: "[PATCH 02/14] mm/hmm: fix header file if/else/endif maze"
Next in thread: Jerome Glisse: "Re: [PATCH 02/14] mm/hmm: fix header file if/else/endif maze"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Fri, 16 Mar 2018 15:14:07 -0400 jglisse@xxxxxxxxxx wrote:

> From: Jérôme Glisse <jglisse@xxxxxxxxxx>
>
> The #if/#else/#endif for IS_ENABLED(CONFIG_HMM) were wrong.

"were wrong" is not a sufficient explanation of the problem, especially
if we're requesting a -stable backport. Please fully describe the
effects of a bug when fixing it?

Next message: Florian Fainelli: "Re: [PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev"
Previous message: Eric W. Biederman: "Re: [PATCH 13/22] signal: Move addr_lsb into the _sigfault union for clarity"
In reply to: jglisse: "[PATCH 02/14] mm/hmm: fix header file if/else/endif maze"
Next in thread: Jerome Glisse: "Re: [PATCH 02/14] mm/hmm: fix header file if/else/endif maze"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]