Re: [PATCH v12 04/22] selftests/vm: typecast the pkey register

From: Dave Hansen
Date: Fri Mar 16 2018 - 17:58:31 EST


On 02/21/2018 05:55 PM, Ram Pai wrote:
> -static inline unsigned int _rdpkey_reg(int line)
> +static inline pkey_reg_t _rdpkey_reg(int line)
> {
> - unsigned int pkey_reg = __rdpkey_reg();
> + pkey_reg_t pkey_reg = __rdpkey_reg();
>
> - dprintf4("rdpkey_reg(line=%d) pkey_reg: %x shadow: %x\n",
> + dprintf4("rdpkey_reg(line=%d) pkey_reg: %016lx shadow: %016lx\n",
> line, pkey_reg, shadow_pkey_reg);
> assert(pkey_reg == shadow_pkey_reg);

Hmm. So we're using %lx for an int? Doesn't the compiler complain
about this?