Re: [PATCH v4 07/10] drivers: qcom: rpmh: cache sleep/wake state requests

[Evan Green]

On Fri, Mar 9, 2018 at 3:27 PM Lina Iyer <ilina@xxxxxxxxxxxxxx> wrote:

> Active state requests are sent immediately to the mailbox controller,
> while sleep and wake state requests are cached in this driver to avoid
> taxing the mailbox controller repeatedly. The cached values will be sent
> to the controller when the rpmh_flush() is called.

> Generally, flushing is a system PM activity and may be called from the
> system PM drivers when the system is entering suspend or deeper sleep
> modes during cpuidle.

> Also allow invalidating the cached requests, so they may be re-populated
> again.

> Signed-off-by: Lina Iyer <ilina@xxxxxxxxxxxxxx>
> ---

> Changes in v4:
>          - remove locking for ->dirty in invalidate
>          - fix send_single
> Changes in v3:
>          - Remove locking for flush function
>          - Improve comments
> ---
>   drivers/soc/qcom/rpmh.c | 203
+++++++++++++++++++++++++++++++++++++++++++++++-
>   include/soc/qcom/rpmh.h |  10 +++
>   2 files changed, 212 insertions(+), 1 deletion(-)


Reviewed-by: Evan Green <evgreen@xxxxxxxxxxxx>