Re: [PATCH v4] EDAC, sb_edac: Remove VLA usage

From: Borislav Petkov
Date: Sat Mar 17 2018 - 00:31:32 EST


On Wed, Mar 14, 2018 at 01:21:32PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wvla, remove VLA and replace it
> with a fixed-length array instead.
>
> Fixed as part of the directive to remove all VLAs from
> the kernel: https://lkml.org/lkml/2018/3/7/621
>
> Also, remove max_interleave as it is no longer useful.
>
> Reviewed-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> ---
> Changes in v4:
> - Remove max_interleave.
>
> Changes in v3:
> - Update macro MAX_INTERLEAVE in order to avoid too long lines.
> This change is based on Mauro's feedback.
> - Update changelog with Mauro's Reviewed-by.
>
> Changes in v2:
> - Use macro max_t to compute the max of all three array sizes.
> This change is based on Borislav's feedback.
>
> drivers/edac/sb_edac.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)

Applied, thanks.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.