Re: [PATCH] phy: core: Allow phy_pm_runtime_xxx API calls with NULL phy

[kbuild test robot]

Hi Manu,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v4.16-rc4]
[also build test WARNING on next-20180316]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Manu-Gautam/phy-core-Allow-phy_pm_runtime_xxx-API-calls-with-NULL-phy/20180317-114302
config: x86_64-randconfig-x002-201810 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/phy/phy-core.c: In function 'phy_pm_runtime_allow':
>> drivers/phy/phy-core.c:215:10: warning: 'return' with a value, in function returning void
      return 0;
             ^
   drivers/phy/phy-core.c:212:6: note: declared here
    void phy_pm_runtime_allow(struct phy *phy)
         ^~~~~~~~~~~~~~~~~~~~
   drivers/phy/phy-core.c: In function 'phy_pm_runtime_forbid':
   drivers/phy/phy-core.c:227:10: warning: 'return' with a value, in function returning void
      return 0;
             ^
   drivers/phy/phy-core.c:224:6: note: declared here
    void phy_pm_runtime_forbid(struct phy *phy)
         ^~~~~~~~~~~~~~~~~~~~~

vim +/return +215 drivers/phy/phy-core.c

   211	
   212	void phy_pm_runtime_allow(struct phy *phy)
   213	{
   214		if (!phy)
 > 215			return 0;
   216	
   217		if (!pm_runtime_enabled(&phy->dev))
   218			return;
   219	
   220		pm_runtime_allow(&phy->dev);
   221	}
   222	EXPORT_SYMBOL_GPL(phy_pm_runtime_allow);
   223	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip