Re: [PATCH v5 0/2] Remove false-positive VLAs when using max()

[Kees Cook]

On Fri, Mar 16, 2018 at 12:27 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> Kees - is there some online "gcc-4.4 checker" somewhere? This does
> seem to work with my gcc. I actually tested some of those files you
> pointed at now.

Unfortunately my 4.4 test fails quickly:

./include/linux/jiffies.h: In function âjiffies_delta_to_clock_tâ:
./include/linux/jiffies.h:444: error: first argument to
â__builtin_choose_exprâ not a constant

static inline clock_t jiffies_delta_to_clock_t(long delta)
{
        return jiffies_to_clock_t(max(0L, delta));
}

I think this is the same problem of using __builtin_constant_p() in
4.4 that we hit earlier? :(

-Kees

-- 
Kees Cook
Pixel Security