Re: [PATCH v2 15/36] fs: add ksys_umount() helper; remove in-kernel call to sys_umount()

[Dominik Brodowski]

On Fri, Mar 16, 2018 at 01:47:50AM -0700, Christoph Hellwig wrote:
> On Thu, Mar 15, 2018 at 08:05:08PM +0100, Dominik Brodowski wrote:
> > Using this helper allows us to avoid the in-kernel call to the sys_umount()
> > syscall.
> 
> kern_unmount, please.  And make it operate on kernel pointers please.

On the naming issue, see my other message from a few days ago. Concerning
the added complexity and the need-for-cleanup in init/do_mounts_initrd.c, I
have added the following comment:

	In the near future, the only fs-external caller of ksys_umount() should be
	converted to call do_umount() directly. Then, ksys_umount() can be moved
	within sys_umount() again.

Thanks,
	Dominik