Re: [PATCH v2 7/9] Staging: iio: accel: adis16201: Prefer reverse christmas tree ordering

From: Jonathan Cameron
Date: Sun Mar 18 2018 - 04:34:56 EST


On Sat, 17 Mar 2018 01:36:24 +0530
Himanshu Jha <himanshujha199640@xxxxxxxxx> wrote:

> Prefer reverse christmas tree ordering of declarations to improve
> readability.
>
> Signed-off-by: Himanshu Jha <himanshujha199640@xxxxxxxxx>
As ever, this sort of change is only worth doing if you are working on the
relevant code anyway. You are, so good to tidy up! (I put that here to
avoid getting lots of people feeling they 'have' to make this sort of
change).

Applied

Thanks,

Jonathan
> ---
> v2:
> -no change in this patch.
>
> drivers/staging/iio/accel/adis16201.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c
> index 298bf90..00e944e 100644
> --- a/drivers/staging/iio/accel/adis16201.c
> +++ b/drivers/staging/iio/accel/adis16201.c
> @@ -259,9 +259,9 @@ static const struct adis_data adis16201_data = {
>
> static int adis16201_probe(struct spi_device *spi)
> {
> - int ret;
> - struct adis *st;
> struct iio_dev *indio_dev;
> + struct adis *st;
> + int ret;
>
> indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
> if (!indio_dev)