Re: [PATCH net] net: fec: Fix unbalanced PM runtime calls

From: Florian Fainelli
Date: Sun Mar 18 2018 - 17:42:41 EST




On 03/18/2018 01:35 PM, David Miller wrote:
> From: Florian Fainelli <f.fainelli@xxxxxxxxx>
> Date: Sun, 18 Mar 2018 12:49:51 -0700
>
>> When unbinding/removing the driver, we will run into the following warnings:
>>
>> [ 259.655198] fec 400d1000.ethernet: 400d1000.ethernet supply phy not found, using dummy regulator
>> [ 259.665065] fec 400d1000.ethernet: Unbalanced pm_runtime_enable!
>> [ 259.672770] fec 400d1000.ethernet (unnamed net_device) (uninitialized): Invalid MAC address: 00:00:00:00:00:00
>> [ 259.683062] fec 400d1000.ethernet (unnamed net_device) (uninitialized): Using random MAC address: f2:3e:93:b7:29:c1
>> [ 259.696239] libphy: fec_enet_mii_bus: probed
>>
>> Avoid these warnings by balancing the runtime PM calls during fec_drv_remove().
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
>
> Applied, thank you.
>
> Queue this up for -stable?

I would be inclined to say yes, it was not exactly easy to track down a
set of commits, since this was changed quite a bit.
--
Florian