Re: [PATCH v1 07/19] arm: dts: mt7623: fix the regulators mmc should use on bananapi-r2

From: Matthias Brugger
Date: Sun Mar 18 2018 - 19:49:38 EST




On 02/23/2018 11:16 AM, sean.wang@xxxxxxxxxxxx wrote:
> From: Sean Wang <sean.wang@xxxxxxxxxxxx>
>
> Both mmc devices on bananapi-r2 board should all use the fixed regulators
> as their power source instead of PMIC MT6323 exports.
>
> Signed-off-by: Sean Wang <sean.wang@xxxxxxxxxxxx>

Pushed to v4.16-next/dts32

Thanks!

> ---
> arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> index f660d15..8ef91d6 100644
> --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> @@ -39,6 +39,15 @@
> };
> };
>
> + reg_1p8v: regulator-1p8v {
> + compatible = "regulator-fixed";
> + regulator-name = "fixed-1.8V";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> reg_3p3v: regulator-3p3v {
> compatible = "regulator-fixed";
> regulator-name = "fixed-3.3V";
> @@ -213,8 +222,8 @@
> bus-width = <8>;
> max-frequency = <50000000>;
> cap-mmc-highspeed;
> - vmmc-supply = <&mt6323_vemc3v3_reg>;
> - vqmmc-supply = <&mt6323_vio18_reg>;
> + vmmc-supply = <&reg_3p3v>;
> + vqmmc-supply = <&reg_1p8v>;
> non-removable;
> };
>
> @@ -227,8 +236,8 @@
> max-frequency = <50000000>;
> cap-sd-highspeed;
> cd-gpios = <&pio 261 GPIO_ACTIVE_LOW>;
> - vmmc-supply = <&mt6323_vmch_reg>;
> - vqmmc-supply = <&mt6323_vio18_reg>;
> + vmmc-supply = <&reg_3p3v>;
> + vqmmc-supply = <&reg_3p3v>;
> };
>
> &pcie {
>