Re: [PATCH 4.15 000/128] 4.15.11-stable review

[Greg Kroah-Hartman]

On Sun, Mar 18, 2018 at 10:36:20PM -0700, Guenter Roeck wrote:
> On 03/18/2018 08:39 PM, Dan Rue wrote:
> > On Sun, Mar 18, 2018 at 12:15:23PM +0100, Greg Kroah-Hartman wrote:
> > > On Sun, Mar 18, 2018 at 11:25:26AM +0100, Greg Kroah-Hartman wrote:
> > > > On Fri, Mar 16, 2018 at 04:22:21PM +0100, Greg Kroah-Hartman wrote:
> > > > > This is the start of the stable review cycle for the 4.15.11 release.
> > > > > There are 128 patches in this series, all will be posted as a response
> > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > let me know.
> > > > > 
> > > > > Responses should be made by Sun Mar 18 15:22:57 UTC 2018.
> > > > > Anything received after that time might be too late.
> > > > > 
> > > > > The whole patch series can be found in one patch at:
> > > > > 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.15.11-rc1.gz
> > > > 
> > > > -rc2 is out to fix a build error on some configs:
> > > >   	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.15.11-rc2.gz
> > > 
> > > And -rc3 is out that at least builds properly:
> > >    	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.15.11-rc3.gz
> > 
> > Sorry to say, this one doesn't build properly either.
> > 
> > I tested the previous build issue on arm64 only, but arm32 is still
> > failing on 4.14/4.15 due to the following:
> > 
> >      07f498834a53 ("clk: ti: clkctrl: add support for retrying failed init")
> > 
> > I'll reply to the patch directly as well.
> > 
> > $ make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=build-arm multi_v7_defconfig
> > $ make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=build-arm
> > 
> > ...
> > 
> > ../drivers/clk/ti/clkctrl.c: In function â_ti_omap4_clkctrl_setupâ:
> > ../drivers/clk/ti/clkctrl.c:497:27: error: passing argument 2 of âti_clk_retry_initâ from incompatible pointer type
> >   [-Werror=incompatible-pointer-types]
> >     ti_clk_retry_init(node, provider, _clkctrl_add_provider);
> >                             ^~~~~~~~
> > In file included from ../drivers/clk/ti/clkctrl.c:24:0:
> > ../drivers/clk/ti/clock.h:265:5: note: expected âstruct clk_hw *â but argument is of type âstruct omap_clkctrl_prov
> > ider *â
> >   int ti_clk_retry_init(struct device_node *node, struct clk_hw *hw,
> >       ^~~~~~~~~~~~~~~~~                                                                                             ../drivers/clk/ti/clkctrl.c:497:37: error: passing argument 3 of âti_clk_retry_initâ from incompatible pointer type
> >   [-Werror=incompatible-pointer-types]
> >     ti_clk_retry_init(node, provider, _clkctrl_add_provider);
> >                                       ^~~~~~~~~~~~~~~~~~~~~
> > In file included from ../drivers/clk/ti/clkctrl.c:24:0:                                                            ../drivers/clk/ti/clock.h:265:5: note: expected âti_of_clk_init_cb_t {aka void (*)(struct clk_hw *, struct device_n
> > ode *)}â but argument is of type âvoid (*)(void *, struct device_node *)â
> >   int ti_clk_retry_init(struct device_node *node, struct clk_hw *hw,
> >       ^~~~~~~~~~~~~~~~~
> > cc1: some warnings being treated as errors
> > make[4]: *** [../scripts/Makefile.build:329: drivers/clk/ti/clkctrl.o] Error 1
> > make[3]: *** [../scripts/Makefile.build:587: drivers/clk/ti] Error 2
> > make[2]: *** [../scripts/Makefile.build:587: drivers/clk] Error 2
> > make[1]: *** [/home/drue/src/linux/4.14-rc/Makefile:1031: drivers] Error 2
> > make[1]: Leaving directory '/home/drue/src/linux/4.14-rc/build-arm'
> > make: *** [Makefile:146: sub-make] Error 2
> > 
> > 
> 
> You are right. Difference in my build is that my version of gcc doesn't produce
> and error but just a warning.

These trees "should" be building with no warnings at all, thanks to the
great effort Arnd put in recently.  If any stable patch is adding
warnings, I'd like to know that as it sometimes hides real issues, like
this one.

thanks,

greg k-h