Re: [PATCH] gpio: mockup: fix a potential crash when creating debugfs entries

[Bartosz Golaszewski]

2018-03-04 13:45 GMT+01:00 Bartosz Golaszewski <brgl@xxxxxxxx>:
> If we failed to create the top debugfs directory, we must not try to
> create the child nodes. We currently only check if gpio_mockup_dbg_dir
> is not NULL, but it can also contain an errno if debugfs is disabled
> in build options. Use IS_ERR_OR_NULL() instead.
>
> Signed-off-by: Bartosz Golaszewski <brgl@xxxxxxxx>
> ---
>  drivers/gpio/gpio-mockup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
> index 3a545ad17817..b5876b07b0f7 100644
> --- a/drivers/gpio/gpio-mockup.c
> +++ b/drivers/gpio/gpio-mockup.c
> @@ -314,7 +314,7 @@ static int gpio_mockup_probe(struct platform_device *pdev)
>         if (rv)
>                 return rv;
>
> -       if (gpio_mockup_dbg_dir)
> +       if (!IS_ERR_OR_NULL(gpio_mockup_dbg_dir))
>                 gpio_mockup_debugfs_setup(dev, chip);
>
>         return 0;
> --
> 2.16.1
>

Hi Linus,

gentle ping for this one as it causes a crash if debugfs is disabled.

Bart