Re: [PATCH] power/hibernate: Make passing hibernate offsets more friendly

From: Rafael J. Wysocki
Date: Mon Mar 19 2018 - 06:10:45 EST


On Tuesday, March 6, 2018 11:53:40 AM CET Mario Limonciello wrote:
> Currently the only way to specify a hibernate offset for a
> swap file is on the kernel command line.
>
> Add a new /sys/power/disk_offset that lets userspace
> specify the offset and disk to use when initiating a hibernate
> cycle.
>
> Also split up the parsing routine to re-use the same code
> for the /sys/power/resume and /sys/power/disk_offset parsing.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxxx>

Well, IMO /sys/power/resume and /sys/power/disk_offset would be confusingly
similar after this patch.

I wonder if adding a resume_offset sysfs attr to simply allow the value of
resume offset alone to be passed to the kernel at run time (in addition to
the command line) would work?

Thanks!