Re: [PATCH] tools: Fix str_error_r() Werror=restrict build

[Sergey Senozhatsky]

On (03/19/18 11:16), Arnaldo Carvalho de Melo wrote:
> Em Mon, Mar 19, 2018 at 02:55:04PM +0900, Sergey Senozhatsky escreveu:
> > Commit c8b5f2c96d1bf6c ("tools: Introduce str_error_r()") added
> > an str_error_r() wrapper which makes gcc8 unhappy due to
> > restrict-qualified parameter aliasing violation:
> > 
> > ../lib/str_error_r.c: In function âstr_error_râ:
> > ../lib/str_error_r.c:25:3: error: passing argument 1 to restrict-qualified parameter aliases with argument 5 [-Werror=restrict]
> >    snprintf(buf, buflen, "INTERNAL ERROR: strerror_r(%d, %p, %zd)=%d", errnum, buf, buflen, err);
> >    ^~~~~~~~
> > cc1: all warnings being treated as errors
> 
> I applied Josh's patch, just printing '[buf]', that is good enough, I
> think.

Sure. Do you need the whole "strerror_r(%d, %p, %zd)" in this case?
Seems that printing out just `errnum' should be good enough.

	-ss