Re: [PATCH net-next v2 1/2] brcmfmac: add new dt entries for SG SDIO settings

From: Alexey Roslyakov
Date: Mon Mar 19 2018 - 12:27:18 EST


Hi, Kalle,
good remark, I'll try to make it clear in next version.

Thank you.


On 19 March 2018 at 23:23, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
> Alexey Roslyakov <alexey.roslyakov@xxxxxxxxx> writes:
>
>> There are 3 fields in SDIO settings (quirks) to workaround some of the
>> SG SDIO host particularities, i.e higher align requirements for SG
>> items. All coding is done the long time ago, but there is no way to
>> change the driver behavior without patching the kernel. Add missing
>> devicetree entries.
>>
>> Signed-off-by: Alexey Roslyakov <alexey.roslyakov@xxxxxxxxx>
>
> The commit log is not clear for me, what does "all coding is done long
> time ago" exactly mean? What code and where?
>
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 12 +++++++++---
>> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> Why net-next? To me it looks like this should go to
> wireless-drivers-next.
>
> --
> Kalle Valo



--
With best regards,
Alexey Roslyakov
Email: alexey.roslyakov@xxxxxxxxx