Re: [PATCH] IB/mlx5: Set the default active rate and width to QDR and 4X

From: Jason Gunthorpe
Date: Mon Mar 19 2018 - 13:53:43 EST


On Fri, Mar 16, 2018 at 10:37:13AM +0800, Honggang LI wrote:
> From: Honggang Li <honli@xxxxxxxxxx>
>
> commit f1b65df5a232 ("IB/mlx5: Add support for active_width and
> active_speed in RoCE"). Before this patch applied, the mlx5_ib
> driver set default active_width and active_speed to IB_WIDTH_4X
> and IB_SPEED_QDR.
>
> When the RoCE port is down, the RoCE port did not negotiate the
> active width with remote side. The active width is zero. If run
> ibstat to require the port status, ibstat will panic as it read
> invalid width from sys file.
>
> This patch restores the original behavior.
>
> Fixes: f1b65df5a232 ("IB/mlx5: Add support for active_width and active_speed in RoCE").
> Signed-off-by: Honggang Li <honli@xxxxxxxxxx>
> Reviewed-by: Hal Rosenstock <hal@xxxxxxxxxxxx>
> Reviewed-by: Noa Osherovich <noaos@xxxxxxxxxxxx>
> drivers/infiniband/hw/mlx5/main.c | 3 +++
> 1 file changed, 3 insertions(+)

Applied to for-next, thanks

Jason