Re: [PATCH] x86/sigreturn: use SYSCALL_DEFINE0
From: kbuild test robot
Date: Mon Mar 19 2018 - 16:18:19 EST
Hi Michael,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on v4.16-rc4]
[also build test ERROR on next-20180319]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Tautschnig-Michael/x86-sigreturn-use-SYSCALL_DEFINE0/20180316-110516
config: i386-randconfig-c0-03200324 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
In file included from arch/x86/kernel/signal.c:28:0:
>> include/linux/syscalls.h:194:18: error: conflicting types for 'sys_sigreturn'
asmlinkage long sys_##sname(void)
^
arch/x86/kernel/signal.c:605:1: note: in expansion of macro 'SYSCALL_DEFINE0'
SYSCALL_DEFINE0(sigreturn)
^~~~~~~~~~~~~~~
In file included from arch/x86/kernel/signal.c:45:0:
arch/x86/include/asm/syscalls.h:37:26: note: previous declaration of 'sys_sigreturn' was here
asmlinkage unsigned long sys_sigreturn(void);
^~~~~~~~~~~~~
--
In file included from arch/x86//kernel/signal.c:28:0:
>> include/linux/syscalls.h:194:18: error: conflicting types for 'sys_sigreturn'
asmlinkage long sys_##sname(void)
^
arch/x86//kernel/signal.c:605:1: note: in expansion of macro 'SYSCALL_DEFINE0'
SYSCALL_DEFINE0(sigreturn)
^~~~~~~~~~~~~~~
In file included from arch/x86//kernel/signal.c:45:0:
arch/x86/include/asm/syscalls.h:37:26: note: previous declaration of 'sys_sigreturn' was here
asmlinkage unsigned long sys_sigreturn(void);
^~~~~~~~~~~~~
vim +/sys_sigreturn +194 include/linux/syscalls.h
bed1ffca Frederic Weisbecker 2009-03-13 191
bed1ffca Frederic Weisbecker 2009-03-13 192 #define SYSCALL_DEFINE0(sname) \
99e621f7 Al Viro 2013-03-05 193 SYSCALL_METADATA(_##sname, 0); \
bed1ffca Frederic Weisbecker 2009-03-13 @194 asmlinkage long sys_##sname(void)
bed1ffca Frederic Weisbecker 2009-03-13 195
:::::: The code at line 194 was first introduced by commit
:::::: bed1ffca022cc876fb83161d26670e9b5d3cf36b tracing/syscalls: core infrastructure for syscalls tracing, enhancements
:::::: TO: Frederic Weisbecker <fweisbec@xxxxxxxxx>
:::::: CC: Ingo Molnar <mingo@xxxxxxx>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip