Re: [PATCHv2 5/5] arm64: allwinner: a64: Add support for TERES-I laptop

From: Maxime Ripard
Date: Mon Mar 19 2018 - 17:28:45 EST


hi,

On Mon, Mar 19, 2018 at 12:47:23PM +0530, afzal mohammed wrote:
> On Sun, Mar 18, 2018 at 09:22:51PM +0100, Maxime Ripard wrote:
> > The first part is supposed to be the name of the boards. I did sed
> > s/leds/teres-i/, and applied, together with all the patches but the
> > PWM (so I had to drop the backlight node as well).
> >
> > Please coordinate with Andre about who should send the PWM support.
>
> Assuming that these patches were applied to your sunxi/dt64-for-4.17
> branch, since PWM support patch is missing, there is a build error,
>
> arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts:129.1-5 Label or path pwm not found
>
> Diff at the end cures it.
>
> (there is another H6 pine 64 DT build error related to header file
> missing)
>
> afzal
>
>
> --->8---
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> index b3c7ef6b6fe5..d9baab3dc96b 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> @@ -126,12 +126,6 @@
> status = "okay";
> };
>
> -&pwm {
> - pinctrl-names = "default";
> - pinctrl-0 = <&pwm_pin>;
> - status = "okay";
> -};
> -
> &ohci1 {
> status = "okay";
> };
>

Thanks for noticing and sending a patch. I've fixed the original
commit.

Maxime

--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature