Re: [PATCH v3 19/20] firmware: add request_firmware_cache() to help with cache on reboot

From: Luis R. Rodriguez
Date: Tue Mar 20 2018 - 13:34:24 EST


On Tue, Mar 20, 2018 at 09:30:55AM +0100, Greg KH wrote:
> On Sat, Mar 10, 2018 at 06:15:00AM -0800, Luis R. Rodriguez wrote:
> > +EXPORT_SYMBOL_GPL(request_firmware_cache);
>
> I know you are just following the existing naming scheme, but please
> let's not continue the problem here. Can you prefix all of the firmware
> exported symbols with "firmware_", and then the verb. So this would be
> "firmware_request_cache",

Sure.

> and the older function would be
> "firmware_request_direct".

Sure, so you want to also rename the old exported symbols, and add a macro
or static inline to enable use of the older names?

> I've stopped here in the patch series, applying the others now, so feel
> free to rebase and resend what I've missed, and the minor fixups for the
> prior patches.

Sure thing.

Luis