Re: 4.9.80 compile failure with X86_VSYSCALL_EMULATION=n due to 9a0be5af

From: Lennart Sorensen
Date: Wed Mar 21 2018 - 12:34:48 EST


On Wed, Mar 21, 2018 at 04:31:03PM +0000, Ben Hutchings wrote:
> On Wed, 2018-03-21 at 17:04 +0100, Greg Kroah-Hartman wrote:
> > On Mon, Feb 12, 2018 at 10:43:25AM -0500, Lennart Sorensen wrote:
> > > Commit 9a0be5af added a reference to vsyscall_pgprot in
> > > arch/x86/mm/kaiser.c but that is undefined if X86_VSYSCALL_EMULATION=n
> > > which on an embedded system where you know how all your software is
> > > compiled is quite likely.
> > >
> > > Of course the condition is always false with that config so the code
> > > will never be run, but the compiler is unhappy.
> >
> > What is the compiler error?ÂÂI have not had any reports of this with all
> > of the varied builds that we currently run on the stable trees.
>
> You already applied a fix for this ("kaiser: fix compile error without
> vsyscall").

Yeah the fix certainly works fine. I was not the only one reporting it.

--
Len Sorensen