Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

From: Arnaldo Carvalho de Melo
Date: Thu Mar 22 2018 - 05:38:08 EST


Em Wed, Mar 21, 2018 at 11:43:58AM -0700, Linus Torvalds escreveu:
> [ Adding PeterZ to participants due to query about lockdep_assert() ]
>
> On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo
> <acme@xxxxxxxxxx> wrote:
> >
> > assert_spin_locked(&cmd->t_state_lock);
> > - WARN_ON_ONCE(!irqs_disabled());
> > + WARN_ON_ONCE_NONRT(!irqs_disabled());
>
> Ugh.
>
> Can't we just replace both of those with a lockdep annotation?

Huh, even better, when that feature gets finished (tglx said it was
being developed, not there yet tho) it'll allow further reduction of the
PREEMPT_RT_FULL patchkit.

- Arnaldo