Re: [PATCH 1/2] r8169: reinstate ALDPS for power saving

[Kai-Heng Feng]

Kai Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> wrote:

> Hopefully Hayes (or Realtek) can shed more lights on the issue. Apparently
> ALDPS and ASPM for r8169 is enabled in different commercial products, just
> not in Linux mainline.

Hayes and Realtek folks,

How do we make this patch going forward?
Do you find the root cause that make this patch got reverted?

I guess ALDPS is no longer needed after commit a92a08499b1f ("r8169:  
improve runtime pm in general and suspend unused ports"), now the device  
gets runtime suspended when link is down.

OTOH, ASPM is still quite useful though. When it's enabled, it can save 1W  
power usage, which is quite substantial for a laptop.

So, I'd like to hear your feedback and make ASPM for r8169 eventually gets  
upstreamed.

Kai-Heng