Re: [PATCH v4 4/6] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

From: Sinan Kaya
Date: Thu Mar 22 2018 - 10:33:20 EST


One more time hopefully without HTML this time.


On 03/22/2018 08:48 AM, okaya@xxxxxxxxxxxxxx wrote:
Can you remove the writeq change if it is too late for me to fix?

This is an infrastructural issue on xtensa arch.

Probably, it won't get fixed today.

AFAIS, even writeq won't compile on this arch. I started questioning this build test.

I found out that the solution is this:

#include <linux/io-64-nonatomic-hi-lo.h>

https://patchwork.ozlabs.org/patch/511801/

I did a compile test with this change on xtensa and it passed. I'll repost with the added diff.

+++ b/drivers/infiniband/hw/cxgb4/iw_cxgb4.h
@@ -46,7 +46,7 @@
Â#include <linux/timer.h>
Â#include <linux/io.h>
Â#include <linux/workqueue.h>
-
+#include <linux/io-64-nonatomic-hi-lo.h>
Â#include <asm/byteorder.h>

Â#include <net/net_namespace.h>