RE: [PATCH v2 1/2] dma-mapping: move dma configuration to bus infrastructure

From: Nipun Gupta
Date: Thu Mar 22 2018 - 11:05:28 EST




> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@xxxxxx]
> Sent: Thursday, March 22, 2018 13:46
> To: Nipun Gupta <nipun.gupta@xxxxxxx>
>
> > +static int amba_dma_configure(struct device *dev)
> > +{
> > + return dma_common_configure(dev);
> > +}
>
> So it turns out we only end with two callers of dma_common_configure
> after this series. Based ont hat I'm tempted with the suggestion
> from Robin to just have amba call platform_dma_configure, and move
> the code from dma_common_configure to platform_dma_configure.

okay, that would be fine, trivial query - will it be okay to include
'linux/platform_device.h' in the AMBA bus? I am reluctant for this change
because of including platform file.

Thanks,
Nipun