Re: [PATCH] net/mlx5/core/fpga/ipsec: Fix use-after-free

[Gustavo A. R. Silva]

Hi Yuval,

On 03/22/2018 01:32 PM, Yuval Shaia wrote:
> On Thu, Mar 22, 2018 at 01:03:42PM -0500, Gustavo A. R. Silva wrote:
> > _rule_ is being freed and then dereferenced by accessing rule->ctx
> >
> > Fix this by copying the value returned by PTR_ERR(rule->ctx) into a local
> > variable for its safe use after freeing _rule_
> >
> > Addresses-Coverity-ID: 1466041 ("Read from pointer after free")
> > Fixes: 05564d0ae075 ("net/mlx5: Add flow-steering commands for FPGA IPSec implementation")
> > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>
> Prefix should not be that long, a short one as this is enough.

Yeah. Actually, I was suspicious about it.

> net/mlx5: Fix use-after-free
>
> Besides that - lgtm.
>
> Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>

I'll send v2 with a short prefix and add your Reviewed-by.

Thanks for the feedback.
--
Gustavo