Re: [PATCH v2] vmw_balloon: fixing double free when batching mode is off

[Nadav Amit]

Oleksandr Natalenko <oleksandr@xxxxxxxxxx> wrote:

> Hi.
> 
> On Mon, Mar 19, 2018 at 7:52 PM, Nadav Amit <namit@xxxxxxxxxx> wrote:
>>> Oleksandr, if you can confirm that it fixes the bug you encountered, it
>>> would be great.
>>> 
>>> Greg, Arnd, on your free time, please let me know if there is any issue
>>> with the patch, and whether you can incorporate it, preferably in 4.16,
>>> since it is a bug-fix that was encountered by Red-Hat customers.
>> 
>> Ping?
> 
> No news from me (yet). We depends on the customer here since we are
> unable to reproduce the issue in-house. If you have a recipe on how to
> trigger it reliably, please let us know, and this will speed up the
> verification process.

Actually, rechecking the bug description, I might have rushed. The bug that
I encountered is related to the vunmap() but it is only caused when batching
is off, while the bug you reported has batching on.

It seems that your sources support batching but do not include b91f108a3d54
(âVMware balloon: Treat init like resetâ), which I think would have solved
the problem. I donât see a mainline kernel that supports batching and does
not have this patch, so it would be helpful to see the exact module that you
use.

Regards,
Nadav