Re: [PATCH] drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs

From: Chris Wilson
Date: Thu Mar 22 2018 - 17:32:06 EST

Next message: kbuild test robot: "[net-next:master 1115/1116] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c:82:5: sparse: symbol 'hclge_inform_reset_assert_to_vf' was not declared. Should it be static?"
Previous message: Alan Tull: "Re: [PATCH v4 04/24] fpga: add device feature list support"
In reply to: Gustavo A. R. Silva: "[PATCH] drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs"
Next in thread: Zhenyu Wang: "Re: [PATCH] drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Quoting Gustavo A. R. Silva (2018-03-22 18:21:54)
> The checks are misleading and not required [1].
>
> [1] https://lkml.org/lkml/2018/3/19/1792
>
> Addresses-Coverity-ID: 1466017
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

Zhenyu?
-Chris

Next message: kbuild test robot: "[net-next:master 1115/1116] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c:82:5: sparse: symbol 'hclge_inform_reset_assert_to_vf' was not declared. Should it be static?"
Previous message: Alan Tull: "Re: [PATCH v4 04/24] fpga: add device feature list support"
In reply to: Gustavo A. R. Silva: "[PATCH] drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs"
Next in thread: Zhenyu Wang: "Re: [PATCH] drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]