Re: [PATCH 01/19] powerpc/powermac: Mark variable x as unused

[christophe leroy]

Le 22/03/2018 Ã 21:19, Mathieu Malaterre a ÃcritÂ:
> Since the value of x is never intended to be read, declare it with gcc
> attribute as unused. Fix warning treated as error with W=1:
>
>    arch/powerpc/platforms/powermac/bootx_init.c:471:21: error: variable âxâ set but not used [-Werror=unused-but-set-variable]
>
> Signed-off-by: Mathieu Malaterre <malat@xxxxxxxxxx>
> ---
>   arch/powerpc/platforms/powermac/bootx_init.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/powermac/bootx_init.c b/arch/powerpc/platforms/powermac/bootx_init.c
> index c3c9bbb3573a..d3ce55dae78f 100644
> --- a/arch/powerpc/platforms/powermac/bootx_init.c
> +++ b/arch/powerpc/platforms/powermac/bootx_init.c
> @@ -468,7 +468,7 @@ void __init bootx_init(unsigned long r3, unsigned long r4)
>   	boot_infos_t *bi = (boot_infos_t *) r4;
>   	unsigned long hdr;
>   	unsigned long space;
> -	unsigned long ptr, x;
> +	unsigned long ptr, x __maybe_unused;

Why not use fault_in_pages_readable() instead of the hardcoded part that 
uses x ?

If you decide to keep it as is, at least x should be declared inside the 
if (bi->version < 4)

Christophe


>   	char *model;
>   	unsigned long offset = reloc_offset();
>   

---
L'absence de virus dans ce courrier Ãlectronique a Ãtà vÃrifiÃe par le logiciel antivirus Avast.
https://www.avast.com/antivirus