Re: [PATCH v3 0/1] can: ucan: add driver for Theobroma Systems UCAN devices

[Wolfgang Grandegger]

Am 23.03.2018 um 10:40 schrieb Jakob Unterwurzacher:
> On 23.03.18 09:32, Wolfgang Grandegger wrote:
>>> * add __func__ to all errors and warnings, and to info where it made
>>> sense
>>
>> The final output messages in the driver should especially be useful for
>> the end user... and not the developer! This is also true for the
>> function names. You already use more "__func__" than all other CAN
>> drivers together. Just my opinion!
> 
> The idea was to make it clear which driver printed the message. In my
> opinion, this is a problem:
> 
>> drivers/net/can/usb$ git grep "No memory left for USB buffer"
>> ems_usb.c:ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ netdev_err(netdev, "No memory left for
>> USB buffer\n");
>> ems_usb.c:ÂÂÂÂÂÂÂÂÂÂÂÂÂ netdev_err(netdev, "No memory left for USB
>> buffer\n");
>> esd_usb2.c:ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ "No memory left for USB
>> buffer\n");
>> esd_usb2.c:ÂÂÂÂÂÂÂÂÂÂÂÂ netdev_err(netdev, "No memory left for USB
>> buffer\n");
>> gs_usb.c:ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ netdev_err(netdev, "No memory left for USB
>> buffer\n");
>> gs_usb.c:ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ "No memory left for
>> USB buffer\n");
>> kvaser_usb.c:ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ "No memory left for USB
>> buffer\n");
>> mcba_usb.c:ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ netdev_err(netdev, "No memory left for
>> USB buffer\n");
>> usb_8dev.c:ÂÂÂÂÂÂÂÂÂÂÂÂ netdev_err(netdev, "No memory left for USB
>> buffer\n");
>> usb_8dev.c:ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ netdev_err(netdev, "No memory left for
>> USB buffer\n");

> But I'm open to other suggestions (use a fixed "ucan: " prefix?) or to
> drop it entirely if you think it is not worth it.

But there is already a device prefix, e.g.:

  peak_usb 1-6:1.0: PEAK-System PCAN-USB adapter hwrev 28 serial FFFFFFFF (1 channel)
  peak_usb 1-6:1.0 can0: attached to PCAN-USB channel 0 (device 255)
  ^^^^^^^^

No need to add another one!

Wolfgang.