Re: [PATCH] tty/nozomi: refactor macros and functions
From: Greg Kroah-Hartman
Date: Fri Mar 23 2018 - 11:27:45 EST
On Tue, Mar 20, 2018 at 06:34:30PM -1000, Joey Pabalinas wrote:
> Cleanup a few messy sections of code by replacing constructs
> like `len__ > TMP_BUF_MAX ? TMP_BUF_MAX : len__` with
> `min_t(u32, len__, TMP_BUF_MAX)` and naming identifiers
> more descriptively (where appropriate).
>
> A few sections were nested pretty deeply and have been
> replaced with shallower (but semantically equivalent) logic.
>
> In addition, simplify and coalesce a few of the
> return paths / loop conditionals and correct a few
> pointless Initializations, redundant parentheses/break
> statements, and inconsistently indented line.
That's a lot of different things to do all in a single patch.
Please break this up into a patch series, doing only one logical "thing"
per patch.
thanks,
greg k-h