RE: [PATCH v1 0/4] platform/x86: mlx-platform: Add bus differed and auto detection functionalities

From: Vadim Pasternak
Date: Fri Mar 23 2018 - 11:59:48 EST




> -----Original Message-----
> From: Darren Hart [mailto:dvhart@xxxxxxxxxxxxx]
> Sent: Friday, March 23, 2018 1:56 AM
> To: Vadim Pasternak <vadimp@xxxxxxxxxxxx>
> Cc: andy.shevchenko@xxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; platform-
> driver-x86@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; jiri@xxxxxxxxxxx;
> Michael Shych <michaelsh@xxxxxxxxxxxx>
> Subject: Re: [PATCH v1 0/4] platform/x86: mlx-platform: Add bus differed and
> auto detection functionalities
>
> On Tue, Feb 13, 2018 at 10:09:32PM +0000, Vadim Pasternak wrote:
> > This patchset:
> > - Adds define for the channels number for mux device.
> > - Adds differed bus functionality.
> > - Changes input for device create routine in mlxreg-hotplug driver.
> > - Adds physical bus number auto detection.
> >
> > Vadim Pasternak (4):
> > platform/x86: mlx-platform: Use define for the channel numbers
> > platform/x86: mlx-platform: Add differed bus functionality
> > platform/mellanox: mlxreg-hotplug: Change input for device create
> > routine
> > platform/x86: mlx-platform: Add physical bus number auto detection
>
> Vadim,
>
> I have rewritten most of the commit messages after parsing through them and
> reviewing the code. I believe they are much more concise now, and make the
> intent of the patches much clearer. I have not changed the patch content (code).
>
> Please review the commit messages for the top 4 commits:
> http://git.infradead.org/linux-platform-drivers-
> x86.git/shortlog/refs/heads/review-dvhart-mellanox
>
> Does this still match your intent?
>

Hi Darren,
Thank you very much for review.

Looks good.

Thanks,
Vadim.

> --
> Darren Hart
> VMware Open Source Technology Center