Re: [PATCH v3 3/3] pinctrl: qcom: Don't allow protected pins to be requested
From: Andy Shevchenko
Date: Fri Mar 23 2018 - 12:32:45 EST
On Fri, Mar 23, 2018 at 6:31 PM, Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Fri, Mar 23, 2018 at 6:21 PM, Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
>
>> bitmap_zero(chip->valid_mask, max_gpios);
>> for (i = 0; i < len; i++)
>> set_bit(tmp[i], chip->valid_mask);
>
> Looking to this code I just realized it would be nice to have
>
> {of,device}_property_read_bitmask() where bitmask_parse() is called.
>
> Since it related to change a binding, I would really take couple of
> days to hear other opinions.
>
> In the above case, you need to supply a string, like
>
> "1-5,16,18,25"
s/bitmask/bitmap/g
--
With Best Regards,
Andy Shevchenko