Re: rcu: Add might_sleep() check to synchronize_rcu()

From: Thomas Gleixner
Date: Fri Mar 23 2018 - 17:33:39 EST


On Fri, 23 Mar 2018, Steven Rostedt wrote:

> On Fri, 23 Mar 2018 22:12:24 +0100 (CET)
> Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
> > synchronize_rcu() lacks a might_sleep() check which would have caught that
> > issue way earlier because it would trigger with the minimal debug options
> > enabled.
> >
> > Add a might_sleep() check to catch such cases.
>
> I'm not against the patch, but really? I would think that
> synchronize_rcu() would pretty much always schedule, and scheduling
> from atomic would have triggered with minimal debug options enabled.

Dunno. The reported splat is here:

https://pastebin.com/raw/puvh0cXE