Re: [PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init()

[Rick Chang]

On Fri, 2018-03-23 at 11:44 +0800, Ryder Lee wrote:
> The error return value should be fixed as it may return EPROBE_DEFER.
> 
> Cc: Rick Chang <rick.chang@xxxxxxxxxxxx>
> Cc: Bin Liu <bin.liu@xxxxxxxxxxxx>
> Signed-off-by: Ryder Lee <ryder.lee@xxxxxxxxxxxx>
> ---
> Âdrivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++--
> Â1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> index 226f908..af17aaa 100644
> --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> @@ -1081,11 +1081,11 @@ static int mtk_jpeg_clk_init(struct
> mtk_jpeg_dev *jpeg)
> Â
> Â	jpeg->clk_jdec = devm_clk_get(jpeg->dev, "jpgdec");
> Â	if (IS_ERR(jpeg->clk_jdec))
> -		return -EINVAL;
> +		return PTR_ERR(jpeg->clk_jdec);
> Â
> Â	jpeg->clk_jdec_smi = devm_clk_get(jpeg->dev, "jpgdec-smi");
> Â	if (IS_ERR(jpeg->clk_jdec_smi))
> -		return -EINVAL;
> +		return PTR_ERR(jpeg->clk_jdec_smi);
> Â
> Â	return 0;
> Â}

Acked-by: Rick Chang <rick.chang@xxxxxxxxxxxx>