Re: [PATCH 0/3] iio: add unit converter

[Jonathan Cameron]

On Fri, 23 Mar 2018 14:59:41 +0100
Peter Rosin <peda@xxxxxxxxxx> wrote:

> On 2018-03-23 14:14, Jonathan Cameron wrote:
> > On Mon, 19 Mar 2018 18:02:43 +0100
> > Peter Rosin <peda@xxxxxxxxxx> wrote:
> >   
> >> Hi!
> >>
> >> This moves the iio-mux driver to a new category, since I think
> >> it will be the single driver in that category forever, and now
> >> I'm adding a new driver that is somewhat similar in nature...
> >>
> >> But that rename is not very interesting, it's just reshuffling.
> >> It's the new driver that I need. Specifically, I need to allow
> >> linear scaling and modification of the type of an io-channel.
> >> I don't know exactly how that is accomplished in the best way,
> >> but this is what I came up with.
> >>
> >> The use cases are an ADC hooked up to measure a "big" voltage by
> >> looking at the midpoint of a voltage divider, and an ADC used
> >> to measure the current by looking at the voltage over a resistor.
> >>
> >> Comments?  
> > It is pretty much how I would have implemented it as well.
> > 
> > Will probably do a detailed review over the weekend.
> > Not convinced entirely on the 'wrapper' naming though.
> > Will think about it...  
> 
> Yeah, let's put 'Wrapper' in the crapper. Not married to it.
> 
> Miscellaneous?
> 
> So, not super-happy about that either. And maybe leave the mux
> where it is? It's just that I have the feeling that the iio-mux
> is never going to get any friends in its category, and the mux
> and the unit-converter are kind of related in that they operate
> on other channels. But maybe that's only logical it you know how
> they are implemented...
Perhaps Analog Front ends?
We could move the amplifier driver into the same directory as well,
though right now that driver is not passing the channels through
(it's often used without there being an IIO ADC behind it I think...)

Jonathan


> 
> Cheers,
> Peter
> 
> > 
> > Jonathan
> >   
> >>
> >> Cheers,
> >> Peter
> >>
> >> Peter Rosin (3):
> >>   iio: rename the multiplexer category to wrapper
> >>   dt-bindings: iio: wrapper: add io-channel-unit-converter
> >>   iio: wrapper: unit-converter: new driver
> >>
> >>  .../{multiplexer => wrapper}/io-channel-mux.txt    |   0
> >>  .../iio/wrapper/io-channel-unit-converter.txt      |  84 +++++++
> >>  MAINTAINERS                                        |  11 +-
> >>  drivers/iio/Kconfig                                |   2 +-
> >>  drivers/iio/Makefile                               |   2 +-
> >>  drivers/iio/multiplexer/Makefile                   |   6 -
> >>  drivers/iio/{multiplexer => wrapper}/Kconfig       |  13 +-
> >>  drivers/iio/wrapper/Makefile                       |   7 +
> >>  drivers/iio/{multiplexer => wrapper}/iio-mux.c     |   0
> >>  drivers/iio/wrapper/iio-unit-converter.c           | 268 +++++++++++++++++++++
> >>  10 files changed, 381 insertions(+), 12 deletions(-)
> >>  rename Documentation/devicetree/bindings/iio/{multiplexer => wrapper}/io-channel-mux.txt (100%)
> >>  create mode 100644 Documentation/devicetree/bindings/iio/wrapper/io-channel-unit-converter.txt
> >>  delete mode 100644 drivers/iio/multiplexer/Makefile
> >>  rename drivers/iio/{multiplexer => wrapper}/Kconfig (53%)
> >>  create mode 100644 drivers/iio/wrapper/Makefile
> >>  rename drivers/iio/{multiplexer => wrapper}/iio-mux.c (100%)
> >>  create mode 100644 drivers/iio/wrapper/iio-unit-converter.c
> >>  
> >   
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html