Re: [PATCH v2 3/6] i2c: i2c-stm32f7: Add initial SMBus protocols support

From: Wolfram Sang
Date: Sat Mar 24 2018 - 18:49:21 EST


On Wed, Mar 21, 2018 at 05:48:57PM +0100, Pierre-Yves MORDRET wrote:
> This patch adds SMBus support for I2C controller embedded in STM32F7 Soc.

> All SMBus protocols are implemented except SMBus-specific protocols.

What does that mean?

>
> Signed-off-by: M'boumba Cedric Madianga <cedric.madianga@xxxxxxxxx>
> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@xxxxxx>
> ---
> Version history:
> v1:
> * Initial
> v2:
> * fix Kbuild test robot issue (Unneeded semicolon)
> ---
>
> fixup! i2c: i2c-stm32f7: Add initial SMBus protocols support
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 377 ++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 368 insertions(+), 9 deletions(-)

That is quite some complexity considering we have I2C_FUNC_SMBUS_EMUL. I
don't mind, but you really want that?

Attachment: signature.asc
Description: PGP signature