Re: [PATCH] of_net: Implement of_get_nvmem_mac_address helper

From: Mike Looijmans
Date: Sun Mar 25 2018 - 04:17:44 EST


On 24-03-18 19:53, Andrew Lunn wrote:
A quick survey for the of_get_mac_address users learns that most of them do
a memcpy (or similar) right after it, so for these drivers the
"of_get_nvmem_mac_address" style signature that performs the memcpy (or
better, ether_addr_copy) is a better fit, e.g.:

int of_get_mac_address(struct device_node *np, void *addr)

Hi Mike

This is a nicer solution, but it is quite a lot of work, there are a
lot of users. Maybe Coccinelle can help?

About 58 of them, yeah. And this looked like such a simple thing when I started it...
https://elixir.bootlin.com/linux/v4.16-rc6/ident/of_get_mac_address
I have no experience with Coccinelle though.



--
Mike Looijmans