Re: [PATCH 1/2] md: dm-verity: aggregate crypto API calls

From: Gilad Ben-Yossef
Date: Mon Mar 26 2018 - 02:32:02 EST


On Sun, Mar 25, 2018 at 9:41 PM, Yael Chemla <yael.chemla@xxxxxxxxxxxx> wrote:
> Current implementation makes multiple crypto API calls per block
> implementation makes multiple crypto API calls per single block,
> forcing underlying crypto tfm implementation to "stop & go",
> leading to under utilization of HW engines.
> To fix it unify calls to crypto init/update/final into a digest call
> with a single sg which contains multiple buffers.
> This is also needed as an enabler for the next patch in the series.
>
>
> Signed-off-by: Yael Chemla <yael.chemla@xxxxxxxxxxxx>
> ---
> drivers/md/dm-verity-target.c | 220 ++++++++++++++++++++++++------------------
> 1 file changed, 127 insertions(+), 93 deletions(-)



Reviewed-by: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx>



--
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru