Re: [PATCH v7 2/6] Documentation: power: Initial effort to document power_supply ABI

From: Greg Kroah-Hartman
Date: Mon Mar 26 2018 - 08:50:31 EST


On Mon, Mar 26, 2018 at 12:40:06PM +0000, Adam Thomson wrote:
> On 26 March 2018 10:57, Greg Kroah-Hartman wrote:
>
> > On Fri, Mar 23, 2018 at 10:12:21AM +0000, Adam Thomson wrote:
> > > This commit adds generic ABI information regarding power_supply
> > > properties. This is an initial attempt to try and align the usage
> > > of these properties between drivers. As part of this commit,
> > > common Battery and USB related properties have been listed.
> > >
> > > Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@xxxxxxxxxxx>
> > > ---
> > > Documentation/ABI/testing/sysfs-class-power | 443
> > ++++++++++++++++++++++++++++
> > > MAINTAINERS | 1 +
> > > 2 files changed, 444 insertions(+)
> >
> > How was this not documented before?
>
> As an FYI, there is some overall documentation under:
>
> Documentation/power/power_supply_class.txt
>
> However, after discussions with Heikki, it was determined something more
> detailed would be useful to help clarify usage.

Oh I agree, it belongs in Documentation/ABI/ like you did here, thank
you so much for that. I was just amazed it wasn't already there...

thanks,

greg k-h